updated added RTMP support. fixes #559 #634
Conversation
…nd allow for it to be missing. Add unit tests for changes. Add in the latest video SWF.
| @@ -357,6 +389,11 @@ vjs.Flash.checkReady = function(tech){ | |||
| // Trigger events from the swf on the player | |||
| vjs.Flash['onEvent'] = function(swfID, eventName){ | |||
| var player = vjs.el(swfID)['player']; | |||
| // ugly, but it smooths over progress and | |||
There was a problem hiding this comment.
Is there an issue that this refers to? Or can you elaborate?
There was a problem hiding this comment.
@iamjem can you answer this? I don't know what this was about myself.
There was a problem hiding this comment.
I think this was specific to the RTMP playback. I was noticing instances where playback would end, but the currenttime and duration components weren't finishing their count up or down. Its possible this has been fixed, and it may be worth re-testing since this was first implemented with version 3 of the codebase.
There was a problem hiding this comment.
Tested streams provided from @bdeitte along with some personal Cloudfront streams with RTMP/RTMPT/RTMPE (seems RTMPS requires additional work to use, may not even be supported by Akamai/Amazon) and this bandaid doesn't seem necessary anymore. Time codes update correctly, progress bar completes, and I get the "ended" event firing at the correct time.
I've removed it in my 559-rtmp-support branch (which should also include other recent RTMP changes from Brian, and from 1 and 2). I think this covers all of the outstanding items we had.
|
Added through #605 |
This request takes in #605 and adds the following: